Support schema-aware context publish in Go SDK#10
Open
jiangpengcheng wants to merge 11 commits into
Open
Conversation
freeznet
reviewed
Jul 15, 2026
freeznet
left a comment
Member
There was a problem hiding this comment.
Review: schema-aware context publish
Well-scoped change. The generated context.pb.go looks like a clean protoc regeneration (consistent msgTypes / goTypes / depIdxs, NumMessages 12 → 14, exporters shifted correctly), Publish keeps its raw-bytes behavior, and the new unit tests cover both the raw and schema-aware paths with a capture stub. A couple of inline points on public-API consistency and runtime compatibility — neither is a hard blocker.
Non-blocking notes:
.ci/helm.shci::verify_total_processed: good fix changing the match from*"$total"to*" ${total}"— the old suffix match would false-positive (e.g.total=1matching a metric value of121).- Example
decodeStudentrelies on trial-and-error decoding across two Avro schemas. Binary Avro isn't self-describing, so decoding with the wrong schema can succeed with garbage instead of erroring. It's fine here since CI asserts exact output values (grade+1), just flagging the latent fragility for anyone copying the example.
freeznet
reviewed
Jul 15, 2026
freeznet
left a comment
Member
There was a problem hiding this comment.
Re-review of "Refine context publish schema API" (fca7030)
Both points from the previous pass are resolved — thanks for the quick turnaround:
- API consistency ✅ —
PublishWithSchemanow takes a hand-written value structPublishMessageSchema(withSchemaDataback tostring) and maps to the wire proto internally viapublishMessageSchemaToProto, mirroring theSinkSchemapattern and keeping the generated type off the public surface. Example and unit test are updated accordingly, and there are no lingering references to the old pointer signature. - Runtime compatibility ✅ — the
PublishWithSchemagodoc now documents that a runner consumingPulsarMessage.schemais required (referencinggeneric-runtime#42) and that older runners silently ignore the proto3 field.
One optional minor note inline. LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests